AutoSave Entity Revision POC

The current merge requests uses the preview API call same as 📌 Autosave PoC Active

it currently does not work with components with a "name" property and it does not for images.

Now I have images working. It is just a POC so just assumes we are using media entities and the src always matches a file which then matches and a media entity

Changing this issue to do that actual save via "Publish" as that is the first functionality we need to add.

📌 Autosave PoC Active was committed for auto-save to the tempstore

Until 📌 The UI only handles resolved props values, hence complex widgets do not show the current value in props form (e.g. image with Media Library Widget) Needs work we will not know the actual target id for media. I have search based on src but this is not the best solution

I think this is ready for review.

This is no longer a POC so changing the Priority

wim leers → made their first commit to this issue’s fork.

wim leers → credited longwave → .

wim leers → credited traviscarden → .

Very much on the right track, but I think in the current state it'll be hard to evolve.

I left a bunch of suggestions that IMHO make this more approachable, and make it easier to iterate on in the future.

WDYT, @tedbow?

see MR comments

I think the e2e failure was random🤞🏻

Created follow-up 📌 Create exception class for invalid data from client Active

tedbow → credited f.mazeikis → .

A thorough review round 🏓

I think there's some crucial bits that are too rough to get merged here:

1. supports only POST but does not restrict the route to that and appears to support updating an entity. Suggested fixes on MR: rename route + controller to be about saving entity revisions, not entities, then it all makes sense.
2. the validation error response is way too unstructured, even after having incorporated @longwave's feedback. This will make surfacing validation errors on the client side unnecessarily cumbersome. All the right pieces exist already. I pointed to them in my MR comments.
3. The helper methods were constructing various kinds of undocumented arrays of doom. This is implied by your comment at https://git.drupalcode.org/project/experience_builder/-/merge_requests/3.... I pushed a handful of commits that improve that.

There are now phpunit (next major) tests failing. But the fail the same way for me on 0.x locally after I pulled the latest 11.x changes. That last 0.x ci passed so maybe it is something in Core 11.x.. Will rerun 0.x