- Issue created by @rhovland
- Merge request !43Issue #3478177 by rhovland: Columns are displayed incorrectly in carousels β (Merged) created by rhovland
- πΊπΈUnited States rhovland Oregon
Fixed and tested.
While I was in there I noticed that the code to set row_classes was duplicated. The first instance of it will never be used if the if statement evaluates false. And it is set again inside the if statement.
- First commit to issue fork.
- πΊπΈUnited States shelane
Looks like there is a bit more wrong with the use of columns. It's intended that if you have 2 columns, the content should appear side by side in a single carousel. I'm not seeing that either before or after this MR.
- πΊπΈUnited States rhovland Oregon
Yeah there's something wrong with the structure in certain circumstances related to adding another level of divs. I'm seeing the wrong number of closing divs when there's two columns but three items.
Trying to make sense of what's going on and fixing it.
- πΊπΈUnited States rhovland Oregon
Ok the problem when there is an uneven number of items causing missing closing tags should be fixed now. This was actually a problem before introducing the row div it just didn't break the html enough to be noticeable before.
I also fixed the positioning of captions with the multi column layout.
-
shelane β
committed 7f776293 on 5.5.x authored by
rhovland β
Issue #3478177 by rhovland, shelane: Columns are displayed incorrectly...
-
shelane β
committed 7f776293 on 5.5.x authored by
rhovland β
Automatically closed - issue fixed for 2 weeks with no activity.