- Issue created by @mably
- Merge request !37Issue #3477774 by mably, mrshowerman: Use a trait to reduce code duplication in formatters → (Merged) created by mably
- First commit to issue fork.
- 🇩🇪Germany mrshowerman Munich
I was able to further reduce duplicate code by moving some parts of the
viewElements()
method into new trait methods. The slight differences between SvgImageFormatter and SvgResponsiveImageFormatter we noticed in 📌 Formatters shouldn't repeat core code Needs review today were respected, especially the cache tags handling 😉 - 🇫🇷France mably
Definitely a nice additional code factorization, thanks @mrshowerman!
- 🇫🇷France mably
Made a few tests, everything seems to work fine.
@grevil do you want to have a look at the MR before I merge it?
Automatically closed - issue fixed for 2 weeks with no activity.
- Issue was unassigned.
- Status changed to Fixed
about 2 months ago 9:51pm 4 December 2024