computedfield vs entity_reference base field

Created on 27 September 2024, 6 months ago

Problem/Motivation

I'm working on a site that uses a computedfield like so:

  $fields['event_experts'] = BaseFieldDefinition::create('entity_reference')
    ->setName('event_experts')
    ->setLabel(t('Event Experts'))
    ->setSetting('target_type', 'node')
    ->setComputed(TRUE)
    ->setClass(ExpertsField::class);

The ExpertsField class extends EntityReferenceFieldItemList, uses ComputedItemListTrait and then implements computeValue().

With the changes here, when I load the edit page for a view of a Search API index that has this field as an exposed field, it results in this error:

TypeError: Drupal\Core\Field\BaseFieldDefinition::createFromFieldStorageDefinition(): Argument #1 ($definition) must be of type Drupal\Core\Field\FieldStorageDefinitionInterface, null given, called in /var/www/html/web/core/modules/views/src/FieldAPIHandlerTrait.php on line 52 in Drupal\Core\Field\BaseFieldDefinition::createFromFieldStorageDefinition() (line 83 of core/lib/Drupal/Core/Field/BaseFieldDefinition.php).

Is it possible that this functionality is incompatible with computed fields based on the entity_reference base field?

Steps to reproduce

Create a custom property on an entity type that uses "entity_reference" and has setComputed(TRUE).
Add a view which adds this field as an exposed filter.
Load the view in the Views UI admin interface.

Proposed resolution

Work out how to create a computed field with the changes from ✨ Continuation Add Views EntityReference filter to be available for all entity reference fields Active .

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

entity system

Created by

🇺🇸United States DamienMcKenna NH, USA

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @DamienMcKenna
Comment 6 months ago →
🇬🇧United Kingdom scott_euser
Hi @damienmckenna

Looks like the only actual code that changed in ✨ Continuation Add Views EntityReference filter to be available for all entity reference fields Active is to core/lib/Drupal/Core/Entity/Plugin/EntityReferenceSelection/DefaultSelection.php . Everything else is either new (ie, the new Views Filter Plugin, which is unused and requires code to use) or is just Tests.

Maybe try reverting that change to DefaultSelection.php in your local just to confirm it is in fact a change there causing the issue?
Comment 6 months ago →
🇳🇿New Zealand quietone

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024