Use DrupalPractice.CodeAnalysis.VariableAnalysis on some test

Actually wonder if this increased coverage?

$result = $this->assertSession()->elementTextEquals('xpath', "//a[contains(@href, '{$href}')]", $text);

If this failed would it have been silent and assigned to the variable?

But changes appear to make sense and didn't break anything.

MR looks good but I am curious about one of the loops that was removed.

Re #5 no change to coverage, elementTextEquals ultimately calls \PHPUnit\Framework\Constraint\Constraint::evaluate which will fail the test if it evaluates to false, regardless of if anything is returned.

All good from me

Added an MR review and this needs a merge with HEAD

Rebased with merge conflicts in phpcs.xml.dist and core/modules/language/tests/src/Functional/LanguageSwitchingTest.php

Believe feedback for this one has been addressed

Applied two suggestions from alexpott, so let's have another review.