- Issue created by @jibla
- Merge request !299Resolve #3476719 "Improve documentation for" → (Merged) created by Unnamed author
- 🇬🇧United Kingdom MrDaleSmith
This MR is 148 commits behind the upstream repository, and adds an AI Provider within the AI module structure: AI Providers should now be separate projects of their own (see https://www.drupal.org/project/openai → as an example) and all the providers within the codebase are deprecated.
I think this should be reworked to meet the issue raised (improve documentation) and remove any changes not related to that (implementing a new provider).
- 🇬🇪Georgia jibla
Thank you for the feedback @mrdalesmith
The dropai_provider included, is not actually a provider, but an example module for the fictional provider explained in the documentation and the files are linked there. My motivation was that ic can help other developers and can be used as a starter code to build new providers.
Alternatively, I can create a separate project and put that module there.
- 🇩🇪Germany marcus_johansson
Hi Giorgi - thank you for the documentation. As @mrdalesmith writes, we should not have it in visible modules directory. The providers and vdb_providers folders will be removed completely before the prod version is released.
if we want an example module, I think you can put it under docs/examples.
Another option is under tests/modules - we already have a provider module there for testing, but having one to showcase how it works as well would be all ok. I've seen that's how they do things with Experience Builder as well.
You should also add "hidden: true" in the info.yml just to make sure it doesn't show up, but modules under tests or docs should not show up anyway.
- 🇬🇪Georgia jibla
@marcus_johansson @mrdalesmith
Thanks, it makes sense- moved module under docs/examples.
- 🇬🇧United Kingdom MrDaleSmith
Your branch is still way behind so the tests aren't running: you need to update the fork and rebase your branch so this can be reviewed properly.
-
marcus_johansson →
committed d00c809d on 1.0.x authored by
jibla →
Resolve #3476719 "Improve documentation for"
-
marcus_johansson →
committed d00c809d on 1.0.x authored by
jibla →