- Issue created by @catch
- First commit to issue fork.
- Merge request !9601Issue #3476435: Add performance test coverage for the node/add page β (Open) created by goz
- π«π·France goz
I add cold and hot tests, but still have to deal with warm tests and maybe ckeditor5.
- π«π·France goz
We could add ckeditor5 and others but which one ?
And does it make sense ?
The purpose it to test performance of node/add page, not depending of field types right ? - πΊπΈUnited States smustgrave
Pipeline appears to have test failures.
Imagine there has to be a better way then super long queries? @catch?
- π¬π§United Kingdom catch
This looks pretty good except for one comment on the MR.
- π«π·France goz
I also add new rules on PerformanceTestTrait::logQuery() to fix queries matching issues.
- πΊπΈUnited States smustgrave
leaning on @catch review on these. Feedback appears to be addressed though
- First commit to issue fork.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Code looks good to me. It would be good to get a follow up to refactor core/tests/Drupal/Tests/PerformanceTestTrait.php to make use of some early returns.
We can put this bit in a method
// Inline query arguments and log the query. $query = str_replace(array_keys($args), array_values(static::quoteQueryArgs($args)), $query); $performance_data->logQuery($query);
and turn a lot of the elseif into simple ifs with an early return
Rebased off 11.x to make sure it still passes as 3 weeks is a long time in performance/query count time.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Tests are failing in the rebase