Replace Core offcanvas by Bootstrap's one

grimreaper → credited maboy → .

grimreaper → credited tocab → .

Putting notes on all the things remaining to do to have a nice Layout Builder with bootstrap offcanvas.

accordion-flush in layout builder?
UI Styles preview:

• fix select
• remove accordion

• remove section
• add block
• configure block
• other contrib modules form:
  • - section library
  • - layout builder browser
  • - layout builder reorder?
  • - layout_builder_block_clone?
  • - https://www.drupal.org/project/drupal/issues/2999491 ✨ Add reusable option to inline block creation Needs review ?
  • - https://www.drupal.org/project/drupal/issues/3134371 ✨ Allow changing the layout of an existing section in Layout Builder UI Needs work ?
• make submit button full width?

Problem for controller returned content of the offcanvas in Layout Builder, there is no way to alter the returned renderable array.

I wanted to improve the display of the "Create content block" link:

Not possible because:
- Controller result is not alterable without event subscriber, and there are no services in themes...
- it is just a link but hook_link_alter is not triggered in theme
- let's create custom CSS, maybe but what about the icon to manage with UI Icons?

So, is it time to think about a companion module?... for all the stuff not possible in a theme but possible in a module...

Still some stuff to do, but I am blocked, and need discussions to end that.

grimreaper → closed merge request !206

grimreaper → credited pdureau → .

Done.

Finally!

Hi there,
is it possible to have a patch for the 5.0.0-beta1 Version? Would be nice to have the "fix offcanvas does not close after form submission" for that version, too.
Thanks in advance.

Hi,

I plan to revert on 5.0.x as the fix on 5.1.x is mixed with Layout Builder support which I don't want to introduce on 5.0.x.

Alright, thanks for answering

Automatically closed - issue fixed for 2 weeks with no activity.