- Issue created by @iancawthorne
- ivnish Kazakhstan
Can you create an MR?
Needs to create settings form textfield like here https://git.drupalcode.org/project/quote/-/blob/4.0.x/src/Form/SettingsF... and save author selector as settings. And use this setting in JS instead of hardcoding like here https://git.drupalcode.org/project/quote/-/blob/4.0.x/js/quote.js?ref_ty...
- 🇬🇧United Kingdom iancawthorne
I don't think that is the problem I'm describing @ivnish.
The issue is the js is trying to select the username using ".comment__author a", but when the username is not a hyperlink, it is in a "span" tag instead of an "a" tag. I think only the js needs to be updated. The form settings don't need to be touched.
I'm unsure how best to rewrite the js to cater for this scenario.
- ivnish Kazakhstan
I don't think that is the problem I'm describing @ivnish.
I understand you correctly.
My solution - use username selector from module settings as other settings as described in comment #2