- 🇺🇸United States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- 🇮🇳India lavanyatalwar
Hey @sunil jolapara, @avpaderno,
As I see there are multiple other phpcs errors in the file. Should I resolve them aswell?
Also you suggested to remove the doc comments from readme.md file, but when I remove those comments, I encounter phpcs errors stating---------------------------------------------------------------------- 3 | ERROR | Missing short description in doc comment 16 | ERROR | Doc comment is empty ----------------------------------------------------------------------
Kindly suggest.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
In a README file, documentation comments are not mandatory. Those errors/warnings are not even shown by GitLab CI.
- 🇮🇳India lavanyatalwar
Okay I'll work upon it.
Also @avpaderno what should I keep the default title in line 124 Liqpay.php and line 57 of LiqpayPages.php (if the string in argument is empty).
Should I keep the title as 'default title' only ? - 🇮🇳India lavanyatalwar
Heyy @avpaderno,
I have fixed the comments you dropped on the MR but now I am not clear about the following warnings of phpcs-------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 124 | WARNING | Only string literals should be passed to t() where possible | | (Drupal.Semantics.FunctionT.NotLiteralString) -------------------------------------------------------------------------------- FILE: ...y-3475949/web/modules/custom/liqpay-3475949/src/Controller/LiqpayPages.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 57 | WARNING | Only string literals should be passed to t() where possible | | (Drupal.Semantics.FunctionT.NotLiteralString) --------------------------------------------------------------------------------
If you could guide me , I would be highly obiliged since I am quite new to drupal community.
- 🇮🇳India lavanyatalwar
Heyy @avpaderno, @sunil jolapara,
I have fixed the phpcs issues that were asked to be resolved and the phpcs pipeline has passed.
Kindly check and merge :) - 🇮🇳India lavanyatalwar
@avpaderno
Worked upon the suggested changes.
Kindly check -
helena zajika →
committed eaa2ad84 on 9.x authored by
sunil jolapara →
Resolve #3475949 "Fix phpcodesniffer issues"
-
helena zajika →
committed eaa2ad84 on 9.x authored by
sunil jolapara →
- 🇺🇦Ukraine Helena Zajika
Thanks for the changes, but not all of them worked correctly. Made adjustments for correct operation.
- 🇮🇳India lavanyatalwar
Hello @helena zajika,
Thank you for the merge! However, I noticed that the credits for the issue were not included. It would be great if you could add them.
Thanks! Automatically closed - issue fixed for 2 weeks with no activity.