- Issue created by @andyg5000
- Merge request !24Issue #2945068 by czigor, BD3: Error at Checkout Review: $payment_details must... β (Open) created by andyg5000
- Issue was unassigned.
- Status changed to Needs review
3 months ago 7:13pm 20 September 2024 - πΊπΈUnited States andyg5000 North Carolina, USA
Merge request for this module submitted. We're just adding the customer->email to the request as an array which works and solves the problem. However, we can also coordinate with the upstream library (commerceguys/authnet) for which I have a pull request to add the data type https://github.com/commerceguys/authnet/issues/39. Since having that merged and a release rolled will likely take some time, I setteld for the "quick and dirty" fix here. If it is merged, we'll change this to :
use CommerceGuys\AuthNet\DataTypes\Customer; ... $transaction_request->addDataType(new Customer([ 'email' => $order->getEmail(), ]));
π Error on refund if payment hasn't been settled Needs review should also be updated to include this in the void request.
- πΊπΈUnited States rhovland Oregon
Email addresses are not required for orders. We shouldn't assume there is one on the order. Based on the code in Entity/Order.php it looks like $order->getEmail() can return an empty string.
- πΊπΈUnited States andyg5000 North Carolina, USA
Good point. Let me confirm that an empty string would break this request and I'll add a condition if necessary.
- πΊπΈUnited States andyg5000 North Carolina, USA
I went ahead and added the condition so we're good either way.