Error on refund if payment hasn't been settled

Thanks for the re-roll Ryan. This is working well, but commerce core doesn't support the balance recalculation properly after a void (see 🐛 Order balance calculation discrepancy for voided and expired payments. Active ).

I've updated the patch to include a forced refresh of the balance. This won't break anything with related to a fix for 3356936, but should be removed once that's resolved.

So there's an issue if you're using authorize and capture. The void button is shown on settled transactions if you previously viewed it when it was unsettled. It's because of the section of code where it checks if it should refresh the status or not is missing capturedPendingSettlement as one of the status codes.

Attached a patch that fixes this problem.

Here is an updated patch to account for changes in the latest release.
Switched commerce_payment.order_updater to use dependency injection
Fixed a couple minor errors in the comments

I screwed up dependency injection in the patch. Here's the correct version

Rebased changes to account for removing the constructor override in OnsiteBase. Tested changes to ensure I added the dependency correctly and everything is good.

This probably needs a test but I'm uncertain how to do that since the changes depend on an external API and service.

Thanks Ryan!

Once we have some feedback on 🐛 Error 33: Email is required (and E00027) Needs review , we should update this MR to include the customer->email element to the request.