Remove modules/same_page_preview

Thanks @cosmicdreams. Yes, early on in XB's development Same Page Preview gave us a head start (so thank you for that module!, plus it's also a great module for outside of XB), but I think at this point XB isn't using it anymore.

One way to find out is to open an MR that removes it from the codebase and see if any tests fail. If none do, I think we're good to remove it.

I've attempted to contribute that change. I was getting errors initially that I didn't have permission to push this change. But I think I worked around that.

I think the changes looks good wrt to this ticket. Moving this to RTBC

Thank you!!! Merged.

#2++

I think this will contribute to the % of PHP code in XB (vs other languages) dropping lower 😜 (See https://git.drupalcode.org/project/experience_builder/-/graphs/808a89d14....)

Oh cool. I didn't know about the chart linked to in #10. But it's a shame that chart separates "JS", "TSX", and "TS" as 3 separate languages. In my opinion those should all count as JavaScript.

Agreed. But we can add it all up :)

Automatically closed - issue fixed for 2 weeks with no activity.