- Issue created by @Logeshvaran
The forum module is leaving Drupal core. I am moving this issue to the contributed project with the others.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I think we either need to add langcode to the index table or skip inserting for the non-default translation
- 🇮🇳India Logeshvaran
@larowlan, Thanks for your reply. Can we follow the schema structure ( Remove the Primary key for NID and TID ) like Drupal 9 (forum_index), which allows the same NID and TID based on the site's available languages? Will it impact the site if we remove the primary key? Please suggest.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Yes it will prevent use of read committed at the db layer
I think adding the langcode feels like the best approach
- 🇬🇧United Kingdom Jons
I've hit a similar problem and it's just when trying to set the Promoted flag in HOOK_node_insert()
Drupal\Core\Entity\EntityStorageException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '897' for key 'forum.PRIMARY': INSERT INTO "forum" ("tid", "vid", "nid") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => 59 [:db_insert_placeholder_1] => 897 [:db_insert_placeholder_2] => 124 ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 817 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).So this is into the main forum table rather than the index.
It could be because I'm calling save() on the node and that triggers forum's presave or insert hooks.
I have to call save() as the hook is downstream of DB update.
I also did a separate load/update/save of the node (after trying just saving the passed-in node) - same result.
Looking at the forum table the current highest vid is 896, ie no 897 present. The insert fails so both attempts to write the record presumably get thrown away.
Node revisions are switched off for this content type.
Trying to catch (and ignore) the exception does not work.Suggest duplicate keys allowed?
- 🇬🇧United Kingdom Jons
Resolution of #6 seems to be to change src/ForumIndexStorage.php by adding a check for an existing record in create() and createIndex() and skipping insert if one does exist. A possible patch is attached
