Problem with "advanced backup" when checking destination "download" and "take site offline"

Created on 18 September 2024, 2 months ago

Updated 19 September 2024, 2 months ago

Problem/Motivation

This is a follow-up issue of 🐛 Download errors, backup files contain trailing HTML, corrupts archive backups Needs work . In that issue, we found out that when doing an advanced backup and checking "Take site offline" and selecting "Download" as the destination, the backup will download, but the site won't leave maintenance mode automatically.

For the time being, we introduced a validation error, when both options are checked, but this should be fixed at its root.

Steps to reproduce

Proposed resolution

Find the root cause, why the site won't leave maintenance mode after doing a backup using the "Download" destination, fix it and remove the validation error.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

5.1

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Comments & Activities

Issue created by @Grevil
Comment 2 months ago →
🇩🇪Germany Grevil
The problem of this lies in "/src/Drupal/Destination/DrupalBrowserDownloadDestination.php". The exit() call will stop further code from executing (including taking the site out of maintenance mode). Removing the exit() call will break the module though (see 🐛 Download errors, backup files contain trailing HTML, corrupts archive backups Needs work ). So we might need to take the site online, before calling exit()!
Comment 2 months ago →
🇩🇪Germany Grevil
Let us also add tests, to check if the created backup file is NOT broken.
Comment 2 months ago →
🇩🇪Germany Anybody Porta Westfalica

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024