fieldset template should respect description display setting (before)

stefan.korn → changed the visibility of the branch 3474642-fieldset-template-should to hidden.

@stefan.korn - thanks for your work!

Before patch application:

After patch application:

Tasks to do:

#1

Add description_display variable to twig comment (like in stable9):

 * Available variables:
 * - attributes: HTML attributes for the fieldset element.
 * - description_display: Description display setting. It can have these values:
 *   - before: The description is output before the element.
 *   - after: The description is output after the element (default).
 *   - invisible: The description is output after the element, hidden visually
 *     but available to screen readers.

#2

Looks like this issue exists in the core as well (templates are being created from StarterKit theme)
Create an issue for Starterkit theme → .

@jannakha: True, that issue exists in the starterkit theme as well. Did not expect that, though I spotted a difference in form-element template template in 💬 form element description does not get description class if description display is set to before Active already.

Wondering why starterkit uses different template from its base theme stable9 at all here ...

Regarding Task #1 I copied over the whole variable twig comment from stable9. This has some additional small changes beside adding description_display part.

see updated MR

I created core issue 🐛 starterkit theme should use same fieldset template than stable9 Active