starterkit theme should use same fieldset template than stable9

Would recommend checking the git history to see if that template was already discussed and added on purpose

starterkit was probably added with #3050384: Provide a starterkit theme in core → . Add I think the issue with description display was fixed with #2396145: Option #description_display for form element fieldset is not changing anything → , but that did not find its way back in starterkit supposedly.

Question is maybe why the fieldset template (and some other templates too) are in the starterkit at all, when they maybe could be delivered from base theme stable9 as well?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

False positive

Hi,

I have executed generate-theme command using starterkit. Below are the screenshots of template files before and after patch. We can see here 'description display before/after conditionals' in after-patch screenshot.

Thanks!

Hi,

I have executed generate-theme command using starterkit. Below are the screenshots of template files before and after patch. We can see here 'description display before/after conditionals' in after-patch screenshot.

Thanks!

Hi,

Please find below before and after patch screenshots. Before applying patch conditions were not working and after applying patch those are working. RTBC from my end.

Thanks!

So we don't have starterkit maintainer so elevating to framework. I don't know process for updating starterkit but this seems reasonable.