Contrib.social

Modernize services: Add autowiring aliases, use autoconfigure, etc

Open on Drupal.org →
Created on 12 September 2024, 7 months ago

Problem/Motivation

This is a quick issue to modernize services, a housekeeping issue.

The attached MR:

  • Clean up services.yml and use modern features
  • Use autoconfigure
  • Use autowire
  • Bumps core dep to the current minimum supported version of core, D10.2, which has the autoconfigure/autowire bits needed.
  • Removes the ID of event subscriber, since its not necessary.
  • Switch to logger aware, via autoconfigure. See also https://www.drupal.org/node/3395436 →
  • Switch to event subscriber autoconfigure. See also https://www.drupal.org/node/3357408 →
  • Implements a postupdate hook to force container invalidation. Invalidation is required at least for the logger aware piece. The same code should be implemented for 🐛 Missing container invalidation update from issue modifying services Active , with a different name, if these get committed separately.
  • Switch event subscriber class to lazily get the configuration. No need to memoize the config object as its a part of the config factory.
  • Makes the event subscriber final (extenders should use service decoration or compiler passes if they truely want to override)
  • Switch event subscriber to private arguments, again, use decoration if downstream needs access to these properties.
📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dpi
  • Merge request !42Resolve #3473753 "Seckit modernize services" → (Open) created by dpi
  • Comment 7 months ago →
    🇦🇺Australia dpi Perth, Australia

    A similar one to this, that I created for entity_usage ✨ Modernize services: Add autowiring aliases, use autoconfigure, etc Fixed

  • Pipeline finished with Failed
    7 months ago
    Total: 438s
    #280863
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇦🇺Australia dpi Perth, Australia
  • Pipeline finished with Success
    7 months ago
    Total: 285s
    #280871
  • Comment 7 months ago →
    🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺

    @dpi thanks for this.

    Sounds like perhaps it'd be good to consider a new 2.1.x branch / set of releases?

    Also, would you consider volunteering as a co-maintainer?

  • Comment 7 months ago →
    🇦🇺Australia dpi Perth, Australia

    A new minor series of this project sounds perfectly reasonable.

    I couldn’t commit as a maintainer as I simply don’t have enough sites that I permanently maintain that utilize this Seckit.

    I’d be happy to play code golf and get linting and max out PHPStan as best as possible, in different issue. That may help with long term maintenance and contribution… if you’d accept that.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024