Deprecate submodule seo_checklist_optional_modules

Created on 11 September 2024, 2 months ago

Problem/Motivation

Version constraints on the seo_checklist_optional_modules submodule are not being kept up to date, and the module itself won't allow removal of an "optional" module for a site that enables this since the dependent modules are required in the info file.

Is it possible to deprecate and remove the module without harming sites that have it installed? The module itself does nothing, but the dependencies would need to be unpacked to the project's composer.json.

We could recreate the functionality in a recipe that requires and possibly configures the modules needed for the checklist, without the long term maintainability of those dependencies.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Active

Version

5.2

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @thejimbirch
  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    Yes, I think we should deprecate seo_checklist_optional_modules. It think it was mostly created for convenience for evaluators and for local development. I would never recommend using it in production. I think recipes present some much more interesting possibilities.

    If anyone is using the module in production, we can't remove it without potentially breaking their site. And we don't want to move the dependencies to our main composer.json, which would exacerbate the problem in several respects. I think it would be best to remove it in a 6.x branch where we can introduce a lot of the other major changes that seem to be coming.

    If the version constraints in the module pose a problem in the meantime, we can loosen or even eliminate them (e.g., change ^2 to >=2.0 or even *).

  • Pipeline finished with Skipped
    2 months ago
    #290860
  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    Oh, interesting. I haven't done this before either, but it looks right based on the documentation you pointed to. Fixed.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024