Contrib.social

Values are missing labels + min_delivery_period and max_delivery_period doesn't have a "days" suffix

Open on Drupal.org →
Created on 9 September 2024, 8 months ago

Problem/Motivation

min_delivery_period and max_delivery_period just show the number of days without any unit.

And the single values should have a label?

Steps to reproduce

Proposed resolution

The module always expect days? So maybe the best bet ist to put the translation string right in the Twig template?

      <div class="stock-status__min-delivery-period">
        {{ min_delivery_period }} {{ 'days'|t }}
      </div>
      <div class="stock-status__max-delivery-period">
        {{ max_delivery_period }} {{ 'days'|t }}
      </div>

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code (commerce_product_availability)

Created by

thomas.frobieter EU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024