Autocomplete field with "STARTS_WITH" enabled

Thanks for the patch. Please make a merge request and indent with spaces. Can you add a test that would have caught this?

Hello there!

I tested the patch and can confirm it is working as expected! The merge request uses spaces rather than TAB to indent, I might need more time to work on the tests, but I hope to commit something by tomorrow.

Thank you!

It doesn't look to me like this patch changes anything. It just divides up the conditional into two if statements.

At first glance, I had the same thought as you, but the difference when we split it into a nested if is that the logic does not fall on the elseif block. This block just validates the query is not FALSE and uses the CONTAINS operator.
elseif (stripos($label, $q) !== FALSE)
Another suggestion would be validating that the operator is empty or equals CONTAINS. Both solutions achieve the same result.

Yes, I see. It would probably be better to use a switch statement for the value of $operator and then if statements within that.

Cool, just using the switch statement was not enough, but putting a break; on STARTS_WITH case does the trick.

About testing, I'm not very used to writing unit tests, following the existing ones I added a few lines and it seemed correct, but I could not test it using PHPUnit using ddev :/

If someone could shed light on how to do the tests properly I would give it a shot.

Thank you!

Hello Liam.

It took me a little while to figure out how to run the tests on my local environments and IDE, but now we have tests for this specific operator.

Do you mind having a look?

PS: For those having the same difficulties I had with tests, here is an excellent article on how to integrate Unit tests with DDEV and PHP Storm: https://drupalize.me/blog/debug-any-drupals-phpunit-tests-phpstorm-ddev-...

Tests are not passing.

Using a switch/case could make the code cleaner and prevent the issue.

      switch ($operator) {
        case 'STARTS_WITH':
          if (str_starts_with($label, $q)) {
            $matches[$label] = [
              'value' => $label,
              'label' => $label,
            ];
          }
          break;

        case 'CONTAINS':
        default:
          if (str_contains($label, $q)) {
            $matches[$label] = [
              'value' => $label,
              'label' => $label,
            ];
          }
          break;
      }
    }

The tests are passing now, also fixed some deprecated code and PHPCS warnings.

Thanks for the patch. Please move the changes regarding ::willReturnCallback() to a separate issue and merge request.

pablonicolas → closed merge request !517

pablonicolas → changed the visibility of the branch 3473045-fix-starts-with-autocompletion to hidden.

pablonicolas → changed the visibility of the branch 3473045-autocomplete-field-with to hidden.

pablonicolas → reopened merge request !517

Done @liam morland. The merge request now only contains commits linked to this specific issue. I will create a new issue soon to fix the PHPCS and PHPCBF warnings.

Thank you!

Looks good.

Automatically closed - issue fixed for 2 weeks with no activity.