- Issue created by @the_g_bomb
- Merge request !74Issue #3473012: Update the Accessibility Tools recipe β (Closed) created by the_g_bomb
- π¬π§United Kingdom the_g_bomb
I am leaving this as draft purely to see how Experience builder pans out.
For Editoria11y to work optimally it should have an inline preview, which works well with Same Page Preview module.
If Experience builder is to land with similar functionality, then we will use that instead.
The question becomes do we add this to add that functionality and then replace it with Experience builder when it is ready?
- π¬π§United Kingdom the_g_bomb
The issue the Same page review module, no londer seems to be causing an issue. It may be worth having a discussion if the accessibility tools recipe can be updated to include the module now to enhance the current functionality.
The related issue is: π Incompatibility with autocomplete entity reference fields Active
- πΊπΈUnited States itmaybejj
If it helps -- the 2.2 branch β with the as-you-edit checker now includes default config that will ignore the same page preview frame and live-check the CKEditor fields instead. It also moves the panel over off the preview pane into the editor column. And it avoids covering the Klaro dialogs.
- Merge request !225Resolve #3473012 "Accessibility tools update for demo" β (Merged) created by the_g_bomb
- π¬π§United Kingdom the_g_bomb
Thanks @itmaybejj, I've teseted the new 2.2 version. Looks good.
I have added some content to Demo Editoria11y based on the content at: https://editoria11y.princeton.edu/demo/
I have also updated the recipe to include the 2.2 branch. This way a demo can include inline/live feedback.
I'll use this to produce a video for potential inclusion in the Singapore Keynote.
- π¬π§United Kingdom the_g_bomb
I should have exported the default content without SEO Tools enabled. I have updated the PR so the content doesn't include default metatag content.
- πΊπΈUnited States phenaproxima Massachusetts
Mostly looks fine but I don't think we need to rely on Pathauto.
- πΊπΈUnited States phenaproxima Massachusetts
Almost, but it looks like a line that shouldn't be there is still there.
- πΊπΈUnited States phenaproxima Massachusetts
Assigning to @pameeela for final review.
- π¦πΊAustralia pameeela
This is a cool idea :) just suggested that the demo page should be unpublished, do you disagree @the_g_bomb?
- π¦πΊAustralia pameeela
Just one other question, since this page exists and obviously has issues, shouldn't I see it on the report? The report is still empty for me:
- πΊπΈUnited States phenaproxima Massachusetts
Back to @the_g_bomb for input.
- π¬π§United Kingdom the_g_bomb
I don't disagree that the page should be unpublished. I'll update the PR.
I'll also reach out to @itmaybejj about the missing data on the report page. That should have data in it.
- πΊπΈUnited States itmaybejj
I think I have this fixed now in RC6 β .
Thank you for finding this -- I had gotten one report of this previously, but hadn't been able to reproduce the bug. Basically -- if you manually uninstall and install the module, everything is fine, but for some reason via the recipe, the optional config was being ignored. It's...not optional any more.
Also -- I attached a patch with some suggested changes to the demo page β .
- πΊπΈUnited States phenaproxima Massachusetts
@itmaybejj - as @thejimbirch artfully put it, recipes know not of "optional". They bring in all the config from an extension of you do something like
config:import:extension_name: '*'
in your recipe.yml. - π¬π§United Kingdom the_g_bomb
I have updated the recipe to import * config. I also changed the default content as per @itmaybej 's patch.
- πΊπΈUnited States phenaproxima Massachusetts
No objections at the code level. Reassigning to @pameeela to confirm that the problem she saw, is fixed.
-
phenaproxima β
committed da5fafc6 on 0.x authored by
the_g_bomb β
Issue #3473012 by the_g_bomb, phenaproxima, itmaybejj, pameeela: Provide...
-
phenaproxima β
committed da5fafc6 on 0.x authored by
the_g_bomb β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 0.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.