- Issue created by @joachim
- First commit to issue fork.
- Merge request !9473Resolve #3472995 "Symfonydeprecationshelper in phpunit.xml.dist" → (Open) created by ankitv18
- Status changed to Needs review
11 months ago 4:23pm 11 September 2024 - 🇮🇳India ankitv18
Hi @joachim,
I've created the MR ~~ not sure if this this is only changes required here.
Please do comment if anything else is needed - 🇺🇸United States smustgrave
@ankitv18 again this was opened and tagged for novice, new users, 2 days ago. Know this has been brought up before. Going to see if someone can reach out.
- Status changed to RTBC
11 months ago 5:54pm 11 September 2024 - 🇬🇧United Kingdom joachim
MR looks good.
NB for committer -- should not be backported to 10! :)
- Status changed to Needs work
11 months ago 6:28pm 11 September 2024 - 🇮🇹Italy mondrake 🇮🇹
Well,
This should be removed, as it's no longer relevant and confusing.
is not correct, in fact. Yes it's confusing, but also it's still relevant, it's parsed for configuration by the code that replaced the Symfony bridge with our own. See
Drupal\TestTools\Extension\DeprecationBridge\DeprecationHandler, and calls inrun-tests.sh.This was left in not to break CI jobs that may have been setting the env variable independently.
Probably it should be replaced with something more meaningful (a full PHPUnit extension with parameters, maybe?), but we should rather go for a deprecation dance here, not plain removal.
- 🇬🇧United Kingdom joachim
> but also it's still relevant, it's parsed for configuration by the code that replaced the Symfony bridge with our own. See Drupal\TestTools\Extension\DeprecationBridge\DeprecationHandler, and calls in run-tests.sh.
Ok, so in that case the comments need to be updated.
What should it say now?
- 🇨🇦Canada Charlie ChX Negyesi 🍁Canada
Maybe SYMFONY_DEPRECATIONS_HELPER is parsed but it does absolutely nothing now and 📌 Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency Fixed added
displayDetailsOnTestsThatTriggerDeprecations="true"which is the only thing that now does something and of course it went in undocumented because there was no phpcs rule to demand documentation and heaven forbid documentation gets written which helps developers.
