- Issue created by @FrankieD3
- First commit to issue fork.
- Merge request !25Issue #3472593: Replace deprecated FormElement with FormElementBase โ (Merged) created by Unnamed author
- Status changed to Needs review
7 months ago 8:25am 9 September 2024 - ๐ฎ๐ณIndia sarwan_verma
Hi,
I have updated the deprecated class in Drupal 10.3.0 and also created MR!25.
Please review and verify.
Thanks!
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
liam morland โ made their first commit to this issueโs fork.
-
liam morland โ
committed 8461b696 on 8.x-2.x authored by
sarwan_verma โ
Issue #3472593: Replace deprecated FormElement with FormElementBase
-
liam morland โ
committed 8461b696 on 8.x-2.x authored by
sarwan_verma โ
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I committed this but realized that this has the effect of dropping compatibility with Drupal 10.2. This version is EOL very soon, so perhaps this is not a problem. Or perhaps a 3.0.x branch should be opened with this change.
- ๐บ๐ธUnited States erutan
Had this pop up and came to the issue queue. :)
I've had a few modules drop support for old point releases recently, so this seems fine.
It would be awkward for someone trying to install it on an unsupported release, but they shouldn't be doing that anyways. The patch you linked for D11 support is RTBC, so pulling in that and whatever other RBTC patches seem solid could make for a 3.0.
-
liam morland โ
committed f2c99225 on 8.x-2.x
Revert "Issue #3472593: Replace deprecated FormElement with...
-
liam morland โ
committed f2c99225 on 8.x-2.x
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I have created a 3.0.x branch and removed this commit from 8.x-2.x.
It would be reasonable to make a 8.x-2.5 release and then focus on 3.0.x. Support for 8.x-2.x can be dropped once Drupal 10.2 is EOL and there is a full release on 3.0.x.
- ๐บ๐ธUnited States erutan
That sounds like a good plan!
I'm hoping to get through testing some of the old RBTC and needs review patches for this project soon.
Automatically closed - issue fixed for 2 weeks with no activity.