- Issue created by @jessebaker
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
The warning started after ๐ CI: remove `phpunit.image` override thanks to upstream fix Fixed was merged, very suspicious.
Ahhhh โฆ it looks like https://git.drupalcode.org/project/experience_builder/-/pipelines/275317 failed, I merged that prematurely! Revertingโฆ
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Is this more accurate, @jessebaker?
- ๐ฌ๐งUnited Kingdom jessebaker
@wim leers yes! The title was written too hastily (by me) in my attempt to get a fork up and running to attempt to fix it and then you jumped on it before I could rename it to be more specific, so thank you!
It looks like my attempted fix for the Cypress test has passed at least once. I'm going to run it a few more times to be a bit more reassured that it's truly solved.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
The distraction/off-topic "CI allowed to fail" one mentioned in #3 is now fixed: #3472316-11: CI: remove `phpunit.image` override thanks to upstream fix โ .
- ๐ฎ๐ณIndia omkar-pd
Sometimes tests fail with this error.
https://git.drupalcode.org/project/experience_builder/-/jobs/26752081) General Experience Builder Can access XB UI and do basic interactions: TypeError: The following error originated from your application code, not from Cypress. > Cannot read properties of null (reading 'style') When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application at <unknown> (http://localhost/web/modules/custom/experience_builder/ui/dist/assets/index.js?v=1:187:3580) at o (http://localhost/web/xb/node/1:3:448) at <unknown> (http://localhost/web/xb/node/1:3:821)
- First commit to issue fork.
- ๐บ๐ธUnited States bnjmnm Ann Arbor, MI
I have a fix for this included in ๐ Redux Sync all single-value types in the SDC test all props form Fixed , but also added a branch here with a partial version of the fix and it's still failing. Issue #3473155 is RTBC so we probably don't need to do much more here, but if there's a delay on that I can extract the full solution from that MR and provide it here.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
๐ Redux Sync all single-value types in the SDC test all props form Fixed landed and @jessebaker confirmed the fix over at #3473155-16: Redux Sync all single-value types in the SDC test all props form โ so โฆ can we close this? ๐
- Issue was unassigned.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Still happening, sadly: https://git.drupalcode.org/project/experience_builder/-/jobs/2727129
- ๐ฌ๐งUnited Kingdom jessebaker
RE #12 it looks like the test is still flakey but it's flakey in a slightly different way now! I think that counts as progress.
I've just fixed conflicts so this branch now has the fixes that were added in ๐ Redux Sync all single-value types in the SDC test all props form Fixed but I'm not able to look into this right now as other issues have priority.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
I don't think I've seen failures in the past 10 days!
- ๐ฌ๐งUnited Kingdom jessebaker
Closing as this was fixed elsewhere.