Fix the issues reported by PHP_CodeSniffer

Created on 5 September 2024, 14 days ago

Updated 7 September 2024, 11 days ago

Problem/Motivation

FILE: websecurity\.gitlab\issue_templates\change.md
---------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------
38 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------

FILE: websecurity\.gitlab\issue_templates\documentation.md
----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------
30 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------

FILE: websecurity\.gitlab\issue_templates\fix.md
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
39 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: websecurity\.gitlab\issue_templates\update.md
---------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------
38 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------

FILE: websecurity\websecurity.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run phpcs command to get the drupal coding standard issues.

Proposed resolution

Many of the issues can be fixed by running the phpcbf command. For the remaining ones, we will need to manually address and then commit these changes before pushing them.

Remaining tasks

✅ File an issue
➖ Addition/Change/Update/Fix
➖ Merge request, Patch, or Commit
➖ Testing to ensure no regression
➖ Automated unit testing coverage
➖ Automated functional testing coverage
➖ UX/UI designer responsibilities
➖ Readability
➖ Accessibility
➖ Performance
➖ Security
➖ Documentation
➖ Code review by maintainers
➖ Full testing and approval
➖ Credit contributors
➖ Review with the product owner
➖ Release notes snippet
❌ Release

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Needs work

Version

11.0

Component

Code

Created by

🇺🇸United States Sunil Jolapara 27 Heron Drive, Amelia, OH, 45102

Live updates comments and jobs are added and updated live.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Merge Requests

!1Fix the issues reported by PHP_CodeSniffer
Open
🇮🇹Italy apaderno
updated 11 days ago

Comments & Activities

Issue created by @Sunil Jolapara
Status changed to Active 11 days ago6:54pm 7 September 2024
Comment 11 days ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Merge request !1Issue #3472329: Fix the issues reported by PHP_CodeSniffer → (Open) created by apaderno
Pipeline finished with Failed
11 days ago
Total: 45s
#276694
Status changed to Needs work 11 days ago7:09pm 7 September 2024
Comment 11 days ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, the .info.yml file does not contain none of the reported lines.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024