- Issue created by @efpapado
- 🇳🇴Norway efpapado
efpapado → changed the visibility of the branch 3472296-provide-an-option to hidden.
- Merge request !57Suggest taxonomy option to use existing vocabulary. → (Merged) created by efpapado
- Status changed to Needs review
7 months ago 10:43am 5 September 2024 - Assigned to wouters_f
- 🇧🇪Belgium wouters_f Leuven
Thanks for your contribution.
I will check it when i got some time.
I do remember some work already happened around this, but I'll come back to this. - 🇧🇪Belgium wouters_f Leuven
Ok so I remember similar functionality already exists.
it exists in the ai_ckeditor submodule.
You can find the code here: https://git.drupalcode.org/project/ai/-/blob/1.0.x/modules/ai_ckeditor/s...
We discussed some of these things in https://www.drupal.org/project/ai/issues/3472421 📌 Minor Improvements to the CK Editor module Fixed .
Marcus finished this ticket off.
You might use the code that exists already for inspiration. - Issue was unassigned.
- Status changed to Needs work
7 months ago 6:51pm 11 September 2024 - Status changed to Needs review
7 months ago 7:10pm 11 September 2024 - 🇧🇪Belgium wouters_f Leuven
ok I've tested it and
1. found a little bug that i fixed right away (it used the wrong variable).
2. ran the following tests:
- if unchecked, it nicely generates tags.
- if checked, if seemed to still give me tags that were not in the tree, but also some that were in there.
I've changed the wordsuggest
tochoose
in the prompt to fix this too.While I'm typing this I'm thinking: Should this be a dropdown in stead of a checkbox (
- generate tags
- Use source vocabulary ONLY
- Use source vocabulary if relevant or generate tags
For now I think it works just fine.
If someone else wants to review this they're welcome! - 🇳🇴Norway efpapado
I suggest you merge it, and we can keep improving it :)
There will be other suggestions also for improvements. - Status changed to RTBC
7 months ago 9:53am 12 September 2024 - Status changed to Fixed
7 months ago 6:01pm 12 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.