Change the project_browser.stage.require and project_browser.activate routes to accept a list of project IDs

Created on 5 September 2024, about 1 month ago
Updated 16 September 2024, about 1 month ago

Problem/Motivation

See #3330887-14: [PP-1] GUI install multiple modules at once. โ†’ for background. But, to quote that:

[Let's change] the project_browser.stage.require route such that:

  • Its URL becomes /admin/modules/project_browser/install-require. (No more {source} or {id} parameters).
  • It is a POST route, not a GET route.
  • The request body needs to be a JSON-encoded array of arrays, where each array is a source ID and project ID. Like this:
    [["some_source","some_project_id"],["some_source","another_project_id"]]
    

In that same issue, let's also change the project_browser.activate route to work the same way, so we can activate multiple projects at once.

Let's get that done and adjust our tests to match. The only test coverage we'll need, I think, is proof that passing multiple projects to each of these routes, actually requires and activates those projects.

โœจ Feature request
Status

Fixed

Version

2.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
  • Starshot blocker

    A potential blocker for Drupal Starshot. More information: http://www.drupal.org/project/starshot

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • First commit to issue fork.
  • Merge request !571Routes changed to POST request โ†’ (Merged) created by narendraR
  • Pipeline finished with Failed
    about 1 month ago
    #274523
  • Pipeline finished with Failed
    about 1 month ago
    Total: 494s
    #274963
  • Pipeline finished with Failed
    about 1 month ago
    Total: 399s
    #274989
  • Pipeline finished with Failed
    about 1 month ago
    Total: 517s
    #275957
  • Pipeline finished with Failed
    about 1 month ago
    Total: 452s
    #277912
  • Pipeline finished with Failed
    about 1 month ago
    Total: 459s
    #279388
  • Pipeline finished with Failed
    about 1 month ago
    Total: 493s
    #279485
  • Pipeline finished with Failed
    about 1 month ago
    Total: 46204s
    #279496
  • Pipeline finished with Failed
    about 1 month ago
    Total: 446s
    #279920
  • Pipeline finished with Success
    about 1 month ago
    Total: 340s
    #279949
  • Status changed to Needs review about 1 month ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India
  • Status changed to Needs work about 1 month ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    This makes a lot of sense. I honestly have very little to complain about here.

  • Pipeline finished with Failed
    about 1 month ago
    #280758
  • Pipeline finished with Success
    about 1 month ago
    Total: 1283s
    #280926
  • Status changed to Needs review about 1 month ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India
  • Status changed to Needs work about 1 month ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    The core logic here looks great. No complaints!

    However, I'd like to see a little bit more rigor in the test changes; the way it was currently done feels a little bit sketchy to me in some places. This is definitely getting there, though, and once we have the tests solidly figured out, I think this is good to go.

  • Pipeline finished with Success
    about 1 month ago
    Total: 788s
    #281486
  • Status changed to Needs review about 1 month ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India
  • Status changed to RTBC about 1 month ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    The clickWithWait() change makes me a little nervous, but I asked @tim.plunkett and he said this has been done before in other issues. It points, probably, to some general jankiness in the tests that is not in scope here.

    So, with that in mind, I have no other complaints; this is good to go.

  • Pipeline finished with Success
    about 1 month ago
    Total: 493s
    #281527
  • Pipeline finished with Success
    about 1 month ago
    Total: 994s
    #281533
  • Pipeline finished with Skipped
    about 1 month ago
    #284626
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States tim.plunkett Philadelphia

    tim.plunkett โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Skipped
    about 1 month ago
    #284629
  • Status changed to Fixed about 1 month ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States tim.plunkett Philadelphia

    Merged!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024