- Issue created by @phenaproxima
- First commit to issue fork.
- Status changed to Needs review
5 months ago 8:28am 11 September 2024 - Status changed to Needs work
5 months ago 1:15pm 11 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
This makes a lot of sense. I honestly have very little to complain about here.
- Status changed to Needs review
5 months ago 8:49am 12 September 2024 - Status changed to Needs work
5 months ago 1:25pm 12 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
The core logic here looks great. No complaints!
However, I'd like to see a little bit more rigor in the test changes; the way it was currently done feels a little bit sketchy to me in some places. This is definitely getting there, though, and once we have the tests solidly figured out, I think this is good to go.
- Status changed to Needs review
5 months ago 6:36pm 12 September 2024 - Status changed to RTBC
5 months ago 7:19pm 12 September 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
The
clickWithWait()
change makes me a little nervous, but I asked @tim.plunkett and he said this has been done before in other issues. It points, probably, to some general jankiness in the tests that is not in scope here.So, with that in mind, I have no other complaints; this is good to go.
- ๐บ๐ธUnited States tim.plunkett Philadelphia
tim.plunkett โ made their first commit to this issueโs fork.
-
tim.plunkett โ
committed 6cb4b7d7 on 2.0.x authored by
narendrar โ
Issue #3472206: Change the project_browser.stage.require and...
-
tim.plunkett โ
committed 6cb4b7d7 on 2.0.x authored by
narendrar โ
- Status changed to Fixed
5 months ago 5:49pm 16 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.