- Issue created by @omkar-pd
- Merge request !2393471448: Update XB to match the latest Drupal 11 phpcs.xml.dist- 2024-09-01 → (Merged) created by omkar-pd
- Status changed to Needs review
7 months ago 4:59am 1 September 2024 - Status changed to RTBC
7 months ago 2:37am 2 September 2024 - 🇳🇿New Zealand danielveza Brisbane, AU
Was going to open this issue myself but I see this one is already done. The pipeline is green, so that suggests the change is correct. But as a sanity check I cloned both phpcs files locally and diffed
local-machine:/tmp/test$ diff -s ex-phpcs core-phpcs Files ex-phpcs and core-phpcs are identical
Looks good to me! Lets get this in so our pipelines are green again
- Assigned to wim leers
- 🇮🇳India utkarsh_33
Assigning it to @wimleers for getting it in quickly and increasing the priority.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Again a trivial change. Nice to see 📌 Enforce strict types in tests Fixed become a reality upstream :)
-
wim leers →
committed 773e0b1e on 0.x authored by
omkar-pd →
Issue #3471448 by omkar-pd, danielveza, utkarsh_33: Update XB to match...
-
wim leers →
committed 773e0b1e on 0.x authored by
omkar-pd →
- Issue was unassigned.
- Status changed to Fixed
7 months ago 7:26am 3 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.