- Issue created by @b.khouy
- Status changed to Needs review
3 months ago 6:48pm 31 August 2024 - Issue was unassigned.
- Status changed to Needs work
3 months ago 7:57am 1 September 2024 - π«π·France pdureau Paris
Thanks a lot Brahim. Can you do a MR instead of a patch?
Why would
EnumPropType
be the only one needingDependencySerializationTrait
? - π²π¦Morocco b.khouy π²π¦ Morocco
I'm not sure if this also affects other complex prop types, as I only have a few components in my project, and they all use primitive prop types (boolean, string, etc.) and enum prop type.
I will test with other prop types and create a merge request. - Merge request !190issue-3471426: use DependencySerializationTrait trait on enum prop types plugin class β (Merged) created by b.khouy
- Status changed to RTBC
3 months ago 2:59pm 1 September 2024 - π²π¦Morocco b.khouy π²π¦ Morocco
I tested all existing prop types and found no serialization errors. This makes sense since, for example, the variant prop type uses enums, so fixing the issue with the enum prop type should also resolve it for the variant.
A merge request has been opened.
- Assigned to pdureau
- Status changed to Needs review
3 months ago 4:22pm 1 September 2024 - π«π·France pdureau Paris
the variant prop type uses enums, so fixing the issue with the enum prop type should also resolve it for the variant.
I am not sure about this sentence.
I tested all existing prop types and found no serialization errors.
This is the most important, I will do the review
- π©πͺGermany Christian.wiedemann
The trait DependencySerializationTrait solves two seralization issues. (Correct me if I am wrong.) First if the plugin uses services and second if the plugin uses the translateable markup. EnumPropType uses translateable markup so this is propable the reason for the bug because summary method uses translateable markup.
So I would move this PropTypePluginBase.
- Issue was unassigned.
- Status changed to Needs work
2 months ago 10:17am 5 September 2024 - π«π·France pdureau Paris
Brahim, can you move the trait use to PropTypePluginBase?
- π²π¦Morocco b.khouy π²π¦ Morocco
@christian.wiedemann
You're right, it would be better to handle this in PropTypePluginBase, ensuring a general fix for all prop types.@pdureau I'll take care of it.
- Assigned to b.khouy
- Issue was unassigned.
- Status changed to Needs review
2 months ago 12:58pm 5 September 2024 - Status changed to Needs work
2 months ago 7:56am 6 September 2024 - π«π·France pdureau Paris
PHPCS is KO
| ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\Component\Plugin\Definition\PluginDefinitionInterface. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
Careful ( I have rebased the branch on git.drupalcode.org, you may need to delete and repull your local)
- Status changed to Needs review
2 months ago 5:44pm 7 September 2024 - Status changed to Fixed
2 months ago 9:03am 8 September 2024 -
pdureau β
committed d3910c26 on 2.0.x authored by
b.khouy β
Issue #3471426 by b.khouy: Use DependencySerializationTrait trait on...
-
pdureau β
committed d3910c26 on 2.0.x authored by
b.khouy β
- Status changed to Fixed
2 months ago 9:36am 8 September 2024