- Issue created by @ultrabob
- Status changed to Needs work
7 months ago 2:57am 31 August 2024 - 🇮🇳India vishal.kadam Mumbai
For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points.
This application can only continue with a project (and a branch) where all the commits (or the majority of the commits) have been done by you.
- Status changed to Needs review
7 months ago 4:47am 31 August 2024 - 🇯🇵Japan ultrabob Japan
In that case, how about:
Node Menu Placer provides a new UI to facilitate the quick placement of nodes in complex menu structures. This module works with the Menu Link Weight module to update the menu settings of the node form.
- Status changed to Needs work
7 months ago 6:59am 1 September 2024 - 🇮🇳India vishal.kadam Mumbai
1. FILE: node_menu_placer.info.yml
core_version_requirement: ^8 || ^9 || ^10
The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.
2. FILE: node_menu_placer.module
/** * @file * Contains Node Menu Placer module functions. */
The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
/** * Implements hook_form_alter(). */ function node_menu_placer_form_node_form_alter(&$form, $form_state, $form_id) {
The hook used is hook_form_FORM_ID_alter and description for that hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID (which is usually indicated by
getFormId()
). - Status changed to Needs review
7 months ago 5:29pm 1 September 2024 - 🇯🇵Japan ultrabob Japan
Thank you for pointing that out. It has been addressed in the 2.0.x branch.
- Assigned to apaderno
- Status changed to RTBC
7 months ago 5:51am 2 September 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution and for your patience with the review process!
I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.
These are some recommended readings to help you with maintainership:
- Dries → ' post on Responsible maintainers
- Maintainership →
- Git version control system →
- Issue procedures and etiquette →
- Maintaining and responding to issues for a project →
- Release naming conventions → .
You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank the dedicated reviewers as well.
- Status changed to Fixed
7 months ago 5:51am 2 September 2024 - 🇺🇸United States cmlara
@avpaderno:
Can you advise what standards you used to validate this contribution as I’ve seen larger modules rejected for being too small.
Automatically closed - issue fixed for 2 weeks with no activity.