Prop select lists don't affect the component

I'm not sure if this would be fixed by 📌 Component props form: map textarea, bool, and select elements to React components Fixed . Even if it is, I think it's worth having this as a separate issue to have a fix for this before that whole issue is ready.

Will look at this today

Based on other comments I saw today fly by, try making these all required in the yaml file and delete component and clear cache and see if this changes anything. I’m on phone and have no power today so not easy for me to check. Wim found that the props config wasn’t getting created for a lot of props and it might only be required fields that have the necessary config to make them work

Backend is sending the right stuff it looks like, the frontend just needs to support it now. Should have fix soon.

The only form elements that are communicating with the backend and form context properly is Input and Textarea right now, so it just needs to be updated to support

Great 👍

Yeah! I'll try it :)

Works great! 😍

There is an error when I tried to change the width value of the two-column component. I think this is a back-end issue because the request payload is a JS object with string values but the backend expects something else. I will open an issue for this.

The website encountered an unexpected error. Try again later.

Drupal\Core\Render\Component\Exception\InvalidComponentException: [width] String value found, but an integer or an object is required/n[width] Does not have a value in the enumeration [25,33,50,66,75] in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).

Glad it works! Just added support for when options are numbers too so u can change the width of the two column now.

effulgentsia → closed merge request !234

effulgentsia → reopened merge request !234

effulgentsia → closed merge request !234

effulgentsia → closed merge request !236

effulgentsia → reopened merge request !234

This looks great. I merged it to 0.x.

In order to merge it, I had to do some `CODEOWNERS` shenanigans. First, I added myself to some of the groups: 📌 Add effulgentsia as code owner of semi-coupled theme engine and UI utils Fixed . That was legitimate. But then, for this issue GitLab was still wanting approval from the `UI` group even though none of this issue's changes were in that group (GitLab should have recognized all the changes as belonging to the more specific groups). So I had to do 📌 Temporarily add effulgentsia as UI code owner Fixed , then merge this issue, and then do 📌 Revert 3471401 Fixed . I hope that was just a one-time fluke and that in general GitLab will process `CODEOWNERS` correctly for most MRs.

Thank you @effulgentsia and @hooroomoo! 🙏 🚀

It's interesting that Github didn't recognize the code owners correctly. 🤔 I wonder if it's because 📌 Add effulgentsia as code owner of semi-coupled theme engine and UI utils Fixed was closed after the MR here was opened? Either way, I'm glad you were able to workaround that so it didn't block this issue from landing 👍

Adding credit to @effulgentsia

Yay! Thanks 🙏

I just tested the XB heading component after updating my code and i works with the SDDS theme turned off 🎉

WIth the SDDS enabled I get errors like below which should be handled in 🐛 Component config entities are incomplete: missing entries for optional props, causing errors in ComponentPropsForm Fixed . Unclear why enabling SDDS surfaces these though.

Steps

git checkout 0.x
git pull
cd ui
npm i
npm run build
xbflush (my alias for deleting all XB config)
drush cr
(test component)

Errors with SDDS enabled even though these are for the XB component:

Warning: Undefined array key "style" in Drupal\experience_builder\Form\ComponentPropsForm->buildForm() (line 73 of /var/www/html/web/modules/contrib/experience_builder/src/Form/ComponentPropsForm.php)

Warning: Trying to access array offset on null in Drupal\experience_builder\Form\ComponentPropsForm->buildForm() (line 73 of /var/www/html/web/modules/contrib/experience_builder/src/Form/ComponentPropsForm.php)

#24: next time, if you decide something deserves merging without the need for the full approval flow:

👆 No need for all that issue queue overhead. Plus, it avoids the polluted commit history.

P.S.: #25: yep, this should've been pulled in those merged changed first, then it'd have worked fine.

#28: yep, well aware, tackling that next!