Contrib.social

Sidebar toggle is not the last button in the row again (Regression)

Open on Drupal.org →
Created on 29 August 2024, 4 months ago
Updated 30 August 2024, 4 months ago

Problem/Motivation

Recent changes to the gin-sticky-form-actions have made the Content Lock button appear as the very last item again. There was a previous issue that resolved this: https://www.drupal.org/project/gin/issues/3292621 →

Steps to reproduce

Install the latest dev-3.x branch of Gin theme
Install, enable and configure Content Lock module with Lock form with js enabled
View a node form

Proposed resolution

I'm unsure whether we should put the Content Lock button in the new "More actions" list or whether to just move it to the left side of all the default node actions.

🐛 Bug report
Status

Closed: won't fix

Version

3.0

Component

Code

Created by

🇨🇦Canada chrisck BC, Canada

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @chrisck
  • Status changed to Postponed: needs info 4 months ago
  • Comment 4 months ago →
    🇨🇭Switzerland saschaeggi Zurich

    I can't reproduce this as the Lock/Unlock buttons should get placed in the new more menu. Maybe you have some custom code in place?

  • Comment 4 months ago →
    🇨🇦Canada chrisck BC, Canada

    @saschaeggi Sorry I need to adjust the steps to reproduce. In the Content Lock settings page (/admin/config/content/content_lock) if Lock form using JS is enabled, then the Unlock button shows up outside of the More menu and is the last item after the sidebar icon. I've tested this with a new Drupal 10 install.

  • Status changed to Closed: won't fix 4 months ago
  • Comment 4 months ago →
    🇨🇭Switzerland saschaeggi Zurich

    Alright thank you. I'll close this as we can't alter this behavior and it might be best to open an issue in the module itself once we get this feature out of beta.

    Cheers!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024