Write an update hook to ensure js_cookie is enabled

This module must be enabled if the hook runs, so we can safely enable js_cookie if it's not enabled!

Not having js_cookie enabled caused a crazy bug for us - the form input was reset on each save ... hard to find!

Sorry, seems I overlooked that, when merging 📌 The js-cookie library is deprecated Fixed .

I'll get on that ASAP.

Done. Please review!

Please enable the module automatically, if not yet enabled: https://drupal.stackexchange.com/questions/269383/how-do-i-programmatica...

Plus https://drupal.stackexchange.com/questions/188322/how-can-i-check-if-a-m...

@anybody I don't think that is needed. In 99.9% of all cases, they won't have the js_cookie module downloaded / required anyway. And since the need to require / download the module manually, they'll surely activate it as well right?

Nope, they should already have the (module) dependency via composer. The module just needs to be enabled.
See https://www.drupal.org/project/js_cookie/ →

So implementing the auto-enabling will save a bunch of unneccessary manual work. But yes, the update message is also important to let them know they should eventually provide the lib locally.

The risk is too high that people don't read the update message and the missing dependency leads to broken functionality with hard to find bugs.

But what would really make sense is adding our requirements snippet for CDN warning at https://www.drupal.org/project/js_cookie/ →

Could you add an issue and snippet over there? Especially in terms of GDPR.

I'll do so!

Didn't realize, that newly added dependency in the module composer.json will automatically download on update. I wonder if that is also the case if there is only the automatically created composer.json by drupal 🤔

It is, the result is just the same.

Alright, that should do the trick. Also tested the update hook. If the js_cookie module is present but not installed, it simply gets installed through the update_hook successfully.

If its not present, we get the following warnings on update:
→

Might make actually make more sense, if we don't even catch the error and let the update abort!

Alright, that makes more sense! Please review!

Automatically closed - issue fixed for 2 weeks with no activity.