Webform XLSX Export Module to Support PHPSpreadsheet ^2.1

Hi,

I have successfully applied the patch, and it is now working for me. I have created a Merge Request (MR!3) for it. please review it?

Thanks!

Also important due to the recently announced library vulnerability. https://github.com/advisories/GHSA-ghg6-32f9-2jp7

$ composer audit
Found 2 security vulnerability advisories affecting 1 package:
+-------------------+----------------------------------------------------------------------------------+
| Package           | phpoffice/phpspreadsheet                                                         |
| Severity          | high                                                                             |
| CVE               | CVE-2024-45048                                                                   |
| Title             | XXE in PHPSpreadsheet encoding is returned                                       |
| URL               | https://github.com/advisories/GHSA-ghg6-32f9-2jp7                                |
| Affected versions | <2.2.1                                                                           |
| Reported at       | 2024-08-29T17:58:27+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
+-------------------+----------------------------------------------------------------------------------+
| Package           | phpoffice/phpspreadsheet                                                         |
| Severity          | medium                                                                           |
| CVE               | CVE-2024-45046                                                                   |
| Title             | PhpSpreadsheet HTML writer is vulnerable to Cross-Site Scripting via style       |
|                   | information                                                                      |
| URL               | https://github.com/advisories/GHSA-wgmf-q9vr-vww6                                |
| Affected versions | <2.1.0                                                                           |
| Reported at       | 2024-08-29T17:56:56+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+

Added a new commit to the MR, in which I bumped phpoffice/phpspreadsheet to ^2.1, dropped dev-dependency vijaycs85/drupal-quality-checker.

The latter kept us on composer 1.x and, by the looks of it, won't work on the (not-so-new-anymore) GitLab CI that Drupal uses nowadays.

After that commit I get:

$ composer audit
No security vulnerability advisories found.

Title update to match the current state of the MR.

Yes, drupal-quality-checker is not maintained anymore so we should remove it. (Also we probably don't need to version composer.lock if we don't have any dev tools anymore.)
Thanks for the MR, I will test it next week.

Have tested this with a few webforms. Changes look good and cell headers and data produced the expected results for me.

Setting to RTBC - I note there is a comment that the composer.lock file can be removed that hasn't been actioned yet, needs works if that is intended to happen here but the changes around the library and v2 compatibility look good to me.

Automatically closed - issue fixed for 2 weeks with no activity.