- Issue created by @Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Before we implement this, what do the maintainers say?
- 🇩🇪Germany Anybody Porta Westfalica
@jacksicksack: Further thoguhts or details where and how this should be placed?
I ran into this in each commerce project where we needed to place the checkout panes in different regions.
- 🇩🇪Germany Grevil
Just had a quick chat on slack with @jsacksick if we should implement this feature. His answer:
Why not [...]
He also said:
But I'd consider this low prio TBH
I think this is particularly important for payment panes
But not sure how you can clarify this from the UI
I'd suggest we create a first MR and wait for feedback 👍
- Assigned to lrwebks
- Status changed to Needs work
10 months ago 10:22am 11 September 2024 - Status changed to Needs review
10 months ago 11:15am 11 September 2024 - 🇩🇪Germany lrwebks Porta Westfalica
Now, the same PHPUnit error as in ✨ Allow admin_description for @CommerceCheckoutPane plugins RTBC occurs, which again seems to be unrelated to the changed made in the MR.
- Status changed to Needs work
10 months ago 3:42pm 11 September 2024 - 🇩🇪Germany Anybody Porta Westfalica
@lrwebks this is simply the wrong approach taken. Please use the same approach for output like you already did well in 🐛 Mapped media fields are overridden with metadata on translation save Needs review !
So I'm a bit disappointed why you hacked it this way here now...Having a dedicated class then like there, (e.g.
pane-default-step
) we can then discuss how to style it less prominent. For the first step please make the font size small and the text in italics. Label and value should have dedicated classes like
<div class="pane-default-step"><span class="pane-default-step__label">Default region:</span> <span class="pane-default-step__value">main</span></div>
After wards please remove the Draft state from the MR.
- Status changed to Needs review
10 months ago 10:20am 12 September 2024 - 🇩🇪Germany lrwebks Porta Westfalica
I have now implemented the system in the same way as ✨ Allow admin_description for @CommerceCheckoutPane plugins RTBC as well as added CSS and a proper test. I agree, that my previous approach was definitely flawed, yet I am still convinced that the use of the
t()
function is necessary here, as we need a way to translate the "Default Step:" label, and concatenating other strings with at()
function that only wraps around the label violates Drupal standards and undermines the purpose oft()
, see t() Concatenation Dos and Don'ts - Status changed to Needs work
10 months ago 2:57pm 19 September 2024 - 🇩🇪Germany Grevil
As there are a few unresolved threads, which do not seem to require maintainer feedback, I'll set the issue to "Needs Work" again.
- 🇩🇪Germany Anybody Porta Westfalica
@lrwebks you can proceed, I left comments.
- 🇩🇪Germany lrwebks Porta Westfalica
Hier ein Screenshot des aktuellen Standes:
- 🇩🇪Germany Anybody Porta Westfalica
Final comment, then I think this is fine for maintainer feedback!
Resulting screenshot looks nice, I like it and already used the information in a project. Small but helpful for site-builders!!
- 🇩🇪Germany Anybody Porta Westfalica
Nice, ready for maintainer feedback or merge :)
- Issue was unassigned.
- Status changed to RTBC
3 days ago 10:41am 4 July 2025 - 🇮🇱Israel jsacksick
I'd say this is a nice UX improvement. However it doesn't output as nicely as in the screenshot on my local test installation.
See the screenshot below:
- 🇮🇱Israel jsacksick
Looks better with GIN, will commit that. Thanks for the contribution!
-
jsacksick →
committed 729923dc on 3.x authored by
lrwebks →
Issue #3470790 by lrwebks, jsacksick, anybody, grevil: Display '...
-
jsacksick →
committed 729923dc on 3.x authored by
lrwebks →
- 🇩🇪Germany Anybody Porta Westfalica
Thank YOU @jsacksick! That's great, we're happy!