Make label and description translatable in config

Or am I wrong @Grevil?

I think you are right! I'll quickly do some testing. Although we probably need some further code added regarding the fallback for label:

    if (empty($info['label'])) {
      $info['label'] = str_replace('-', ' ', Unicode::ucfirst($attribute_formatted));
    }

That should do the trick.

Sorry but that won't work, you'll just have @label translated with @label. Otherwise we'd have to translate the variable itself... I think we should just leave it as-is. I'm even a fan of requiring the label... ;) That would also fix this!

Ah just saw we can't require a label as it's plain config. So let's just revert the t() call and merge it.

Aight!

Make sense 😅

The upgrade path here added the container_class attribute even if it wasn't configured. This results in adding the attribute to sites that have removed it. Opened 🐛 menu_link_attributes_update_8002 adds container_class attribute if disabled Active

Thanks @acbramley I think that's expected and by design, see the follow-up comment. Thanks for the report anyway!

Automatically closed - issue fixed for 2 weeks with no activity.