- Issue created by @Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Next step should be a test for the early bootstrapping functionality. Eventually we can just test update.php somehow?
- 🇩🇪Germany Anybody Porta Westfalica
Quickfix works as expected, I'm merging this and will tag a hotfix release, so this can be solved cleanly afterwards. Saving people from running into this.
- Status changed to Needs work
4 months ago 5:59pm 27 August 2024 - First commit to issue fork.
- 🇩🇪Germany Grevil
Crazy, that this doesn't come up on runtime but only when running `update.php` / `drush updb`, I would've never thought, that Drupal goes through all defined event calls when updating!
I'll definitely add a test for this!
- Merge request !25Issue #3470557 by anybody: \Drupal::$container is not initialized yet → (Merged) created by Grevil
- Issue was unassigned.
- Status changed to Needs review
4 months ago 8:49am 28 August 2024 - 🇩🇪Germany Grevil
Ok, ready for review!
I am quite unsure about this change... I think we should NOT merge it like this and instead simply drop the fast404 compatibility...
moduleHandler->moduleExists
is a simply too hardware intensive call and we call it twice per request now...
This could easily lead to people abusing the module for DDoS attacks.I'd say we tag https://git.drupalcode.org/project/perimeter/-/commit/b01aeb2be8ef6493cf... as the last fast404 compatible release (3.0.4 if that is possible??), deprecate 3.0.3 and create a new 3.1.0 release without the fast404 compatibility.
- 🇩🇪Germany Grevil
Update: current version still works with the base install of fast404.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @grevil, test seems to work as expected and I left a comment on that @todo.
Thanks for also testing this with fast_404 (#15). If this can be used without the additional logic, that's even better than before!
- Assigned to Grevil
- Status changed to Needs work
4 months ago 11:37am 28 August 2024 - Issue was unassigned.
- Status changed to Needs review
4 months ago 1:26pm 28 August 2024 - Status changed to RTBC
4 months ago 2:26pm 28 August 2024 - Status changed to Fixed
4 months ago 2:30pm 28 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.