- Issue created by @Anybody
- Assigned to Grevil
- Status changed to Needs review
8 months ago 2:39pm 26 August 2024 - 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Works now. I'd like to keep the machine name passed.
Still we have another issue:
Even if there's no output, the field is treated as not empty, so the label is shown. The reason is that all conditions in the template are false, but the isEmpty() check of the field formatter is still true, as there's an availability status set.I'm unsure if we should fix that separately and if there's a case to configure it like this at all...
Maybe dedicated follow-up?
- First commit to issue fork.
- Status changed to RTBC
8 months ago 7:56am 6 September 2024 - 🇩🇪Germany Grevil
@anybody, agreed this isn't easily done, because the "isEmpty()" would theoretically need to know the currently set formatter settings (to see which property is enabled) to 100% ensure the isEmpty logic, but having a field type method depend on a formatter setting doesn't sound like a good idea! 😛
But yea I'll create a follow up issue for this.
LGTM!
- Status changed to Fixed
8 months ago 8:22am 6 September 2024 - Issue was unassigned.
- 🇩🇪Germany Grevil
Created the "follow-up" issue here: 🐛 Field Type "isEmpty()" method logic does not sync with template logic Active . Wouldn't even declare this as a follow-up issue.
Automatically closed - issue fixed for 2 weeks with no activity.