- Issue created by @arousseau
- 🇩🇪Germany Anybody Porta Westfalica
@arousseau I agree with your arguments. Could you prepare a MR perhaps?
Hi! I went through the code of this module and was wondering about the "max-age" block configuration parameter.
Is there a specific need for this parameter?
If I understand correctly, the module provides a simple placeholder element, instead of rendering the whole block as part of the request for the page containing it. So wouldn't it be ok to cache it indefinitely?
The configured "block_ajax" max-age is also used for the AjaxBlockResponse. Is there a reason why this response does not extend CacheableJsonResponse, to instead use the cache metadata provided by the block being rendered?
If it sounds ok and if I'm not missing something, I would be willing to make the adjustments to:
Active
3.0
Code
@arousseau I agree with your arguments. Could you prepare a MR perhaps?