- Issue created by @spokje
- Status changed to Needs work
9 months ago 8:59am 26 August 2024 - 🇳🇱Netherlands spokje
To me it looks like the current value of
ResourceAttributes::DEPLOYMENT_ENVIRONMENT
, being'local'
, should now come from a GitLab variable?But what do I know about performance tests on core: Absolutely nothing!
- 🇬🇧United Kingdom catch
I think it can be s/DEPLOYMENT_ENVIRONMENT/DEPLOYMENT_ENVIRONMENT_NAME/g
- Status changed to Needs review
9 months ago 10:44am 26 August 2024 - 🇳🇱Netherlands spokje
Thanks @catch.
That proved that:
a) I indeed have no knowledge about performance testing on core.
b) I completely misunderstood the needed changes in my comment #4.Oh well, NR :)
- Status changed to RTBC
9 months ago 11:01am 26 August 2024 - 🇬🇧United Kingdom catch
This looks great - we don't really use this as such because it's designed for sites using OpenTelemetry for production monitoring, whereas our (mis-) use of it for performance testing doesn't have any concept of stage/dev/prod. Looks like they just renamed the constant so straightforward change.
- 🇬🇧United Kingdom catch
Actual change is trivial so even though I RTBCed this I'm going to go ahead and commit it. Committed/pushed to 11.x, thanks!
I think we should do the same thing in 10.4.x, so moving there for backport.
- Status changed to Downport
9 months ago 1:26am 29 August 2024 - Status changed to Needs review
9 months ago 5:40am 29 August 2024 - Status changed to Fixed
9 months ago 5:49am 29 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.