Contrib.social

"handleBannedUrls()" is executed twice on 404 pages

Open on Drupal.org →
Created on 26 August 2024, 3 months ago
Updated 8 September 2024, 3 months ago

Problem/Motivation

Through ✨ Make perimeter compatible with fast404 module and use DI for ban.ip_manager Fixed , we introduced multiple KernelEvent subscriber methods to make this module fast404 compatible. Unfortunately, this results in multiple "handleBannedUrls()" calls, when fast404 isn't installed.

Steps to reproduce

  • Go to a banned URL, which resolves to a 404 not found error
  • Call kint() or var_dump() at the start of "handleBannedUrls".
  • The method executes twice.

Proposed resolution

Only call this method once, but still be compatible with fast404.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024