- Issue created by @catch
- Status changed to Needs review
5 months ago 11:09am 26 August 2024 - 🇬🇧United Kingdom catch
Since this adds a bit of complexity, tried to tidy up the overall logic to make it more parseable at the same time.
- 🇬🇧United Kingdom catch
This keeps the four kernel test jobs at around 2 minutes each while removing @group #slow from dozens of tests.
https://git.drupalcode.org/project/drupal/-/jobs/2553451
https://git.drupalcode.org/project/drupal/-/jobs/2553452
https://git.drupalcode.org/project/drupal/-/jobs/2553453
https://git.drupalcode.org/project/drupal/-/jobs/2553454 - Status changed to Needs work
5 months ago 12:21pm 27 August 2024 - Status changed to Needs review
5 months ago 1:01am 28 August 2024 - 🇬🇧United Kingdom catch
Rebased.
Note the weighting by test type doesn't affect core tests, but I'm hoping it will allow us to optimise contrib test run times/resource usage.
- 🇺🇸United States smustgrave
Drupal\Tests\image\Functional\ImageStylesPathAndUrlTest::testImageStyleUrlAndPathPrivateLanguage Behat\Mink\Exception\ExpectationException: Current response status code is 403, but 200 expected. /builds/project/drupal/vendor/behat/mink/src/WebAssert.php:888 /builds/project/drupal/vendor/behat/mink/src/WebAssert.php:145 /builds/project/drupal/core/modules/image/tests/src/Functional/ImageStylesPathAndUrlTest.php:315 /builds/project/drupal/core/modules/image/tests/src/Functional/ImageStylesPathAndUrlTest.php:113 FAILURES!Appears random right?
- Status changed to RTBC
5 months ago 9:12pm 31 August 2024 - 🇬🇧United Kingdom catch
Rebased here after a few more test optimisation issues landed and to try to get a clean pipeline. Most recent pipeline on the MR now is green and took 5m41s https://git.drupalcode.org/project/drupal/-/pipelines/274771
- 🇬🇧United Kingdom catch
No longer applied. Rebase wasn't clean but mering in 11.x was.
- Status changed to Needs work
4 months ago 9:28pm 19 September 2024 - First commit to issue fork.
- Status changed to Needs review
4 months ago 3:21am 20 September 2024 - Status changed to RTBC
4 months ago 10:09am 20 September 2024 - 🇬🇧United Kingdom catch
The changes look good. match(TRUE) still feels like cheating to me but it is a lot more compact so I just need to get used to it. I think I can RTBC since it was just tweaks.
-
longwave →
committed 94b717e9 on 11.x
Issue #3470179 by catch, quietone: Account for test type, number of...
-
longwave →
committed 94b717e9 on 11.x
- Status changed to Fixed
4 months ago 5:28pm 20 September 2024 - Status changed to Downport
4 months ago 5:30pm 20 September 2024 - 🇬🇧United Kingdom longwave UK
Again, maybe we want to backport this to 10.4.x? Doesn't apply cleanly to run-tests.sh unfortunately.
- 🇬🇧United Kingdom catch
I was able to get a clean backport by first backporting 📌 Order tests by number of public methods to optimize gitlab job times Fixed . Only use statements conflicted after that, so went ahead.
- Status changed to Fixed
4 months ago 7:02am 21 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.