Contrib.social

Do not use "items" for SDDS variables as it confuses SDC YAML syntax

Open on Drupal.org →
Created on 23 August 2024, 4 months ago
Updated 29 August 2024, 4 months ago

Problem/Motivation

SDC YAML syntax has uses "items" but we have existing Twig "variables" that are called "items".

When converting to SDC, these "items" props are confused as YAML "items".

Steps to reproduce

Proposed resolution

Rename the "items" in Twig to something more description, e.g. "menu_items", and the update the YAMLs to match.

kristens-mbp-2:components kristenpol$ grep -r " - items" . |grep twig
./04-templates/page/page.twig: * - items: [array] Array of alternative links.
./03-organisms/navigation/navigation.twig:  * - items: [array] Array of menu items.
./03-organisms/mobile-navigation/mobile-navigation-menu.twig: * - items: [array] Menu links array. Each item contains:
./03-organisms/side-navigation/side-navigation.twig: * - items: [array] Array of menu items.
./00-base/item-list/item-list.twig: * - items: [array] Items array
./00-base/menu/menu.twig: * - items: [array] Menu links array. Each item contains:
./00-base/grid/grid.twig: * - items: [array] Array of column items.
./02-molecules/pagination/pagination.twig: * - items: [array] Array of pagination items:
./02-molecules/single-filter/single-filter.twig: * - items: [array] Filter links:
./02-molecules/social-links/social-links.twig: * - items: [array] Array of items:

Remaining tasks

  • Update component variables
  • Update YAML files
  • Review and test

User interface changes

API changes

Data model changes

📌 Task
Status

Postponed

Version

1.0

Component

Code

Created by

🇺🇸United States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024