[2.0.0-beta2] plugin.manager.sdc conflict with Experience Builder

christian.wiedemann → made their first commit to this issue’s fork.

I decorated plugin.manager.sdc instead of overwriting and I updated the layout builder deriver to use the original service.

Cool, I will review

Pipeline issues

phpstan:

Line modules/ui_patterns_devel/tests/src/Kernel/TwigValidatorTestBase.php
39 Property
Drupal\Tests\ui_patterns_devel\Kernel\TwigValidatorTestBase::$componentPluginManager
(Drupal\ui_patterns\ComponentPluginManager) does not accept
Drupal\Core\Theme\ComponentPluginManager.
------ --------------------------------------------------------------------------------------
Line modules/ui_patterns_devel/tests/src/Kernel/ValidatorTest.php
46 Property
Drupal\Tests\ui_patterns_devel\Kernel\ValidatorTest::$componentPluginManager
(Drupal\ui_patterns\ComponentPluginManager) does not accept
Drupal\Core\Theme\ComponentPluginManager.
------ ------------------------------------------------------------------------------
Line modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php
65 Property
Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase::$componentPluginManager
(Drupal\ui_patterns\ComponentPluginManager) does not accept
Drupal\Core\Theme\ComponentPluginManager.
------ -----------------------------------------------------------------------
Line modules/ui_patterns_layouts/src/Plugin/Derivative/ComponentLayout.php
41 Call to an undefined method
Drupal\Core\Theme\ComponentPluginManager::getSortedDefinitions().
------ ---------------------------------------
Line src/ComponentPluginManager.php
14 Plugin definitions cannot be altered.
------ ---------------------------------------
Line src/Element/ComponentForm.php
172 Call to an undefined method
Drupal\Core\Theme\ComponentPluginManager::getGroupedDefinitions().
------ ----------------------------------------------------------------------
Line tests/src/Kernel/ComponentPluginManagerTest.php
43 Property
Drupal\Tests\ui_patterns\Kernel\ComponentPluginManagerTest::$manager
(Drupal\ui_patterns\ComponentPluginManager) does not accept
Drupal\Core\Theme\ComponentPluginManager.

Maybe more.

Tests without experience builder

After switching to the branch, I got:

Uncaught PHP Exception Error: "Typed property Drupal\ui_patterns\ComponentPluginManager::$propTypePluginManager must not be accessed before initialization" at /home/pierre/Projects/Drupal/ui_patterns_2/web/modules/custom/ui_patterns/src/ComponentPluginManager.php line 59

A fresh install fixed this. Do we really need to do such a fresh install?

Everything seems fine: summary is created, props are typed...

Test 1 with Experience Builder

commit 938ca03cce282bdc79da802efd0d3850751994d3 (HEAD -> 0.x, origin/HEAD, origin/0.x)
Date: Thu Aug 22 18:34:17 2024 +0000

UI Patterns 2 with experience builder components

/patterns/experience_builder shows the Experience Builder's SDC component ✅

Except the resolution of "$ref":"json-schema-definitions:// but tit seems the stream wrapper is not ready at the XB side

Component "Shoe button" can be used with ComponentBlock ✅

Experience builder with the UI Patterns 2 component

This warning: PHP Warning: Undefined array key "props" in experience_builder/src/Plugin/ComponentPluginManager.php on line 58

And a fatal error on /xb/node/1: An unexpected error has occurred while fetching layouts. SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

So, not possible to test more.

Test 2 with Experience Builder

After a git pull, npm i & nom run build:

commit 7cb3623d22582ba7eae4dfb551a402c7d5a1c45c (HEAD -> 0.x, origin/HEAD, origin/0.x)
Date: Wed Aug 28 15:26:32 2024 +0000

I have this fatal: Drupal\experience_builder\PropShape::resolveSchemaReferences(): Argument #1 ($schema) must be of type array, string given

A fresh Drupal reinstall is not fixing it. So, not possible to test more.

Moved to beta3 because:

• There is many active and breaking changes currently nExperience builder
• We may need to push a fix in Core before anyway

Let's do ✨ ComponentPluginManager must implement CategorizingPluginManagerInterface Active first

Let's resume this task.

@christian.wiederman: can you rebase your work and check if the pipelien is OK after the rebase?

Once done, I will redo the tests with Experience Builder.

According to the pipeline, there are 6 PHPCS errors to fix.

Maybe you need to write:

    /* @phpstan-ignore method.notFound */

Instead of:

    /** @phpstan-ignore method.notFound */

?

Experience builder & UI Patterns 2 can be both installed in a Drupal instance. So, I am OK for merge.

Christian, can you rebase your branch and merge to 2.0.x?

Follow-up issue to create by pdureau:

• When using XB components in UIP2: XB's json-schema-definitions stream wrapper is not triggered by UI Patterns 2 (normally, it must be done automatically by the JSON Schema library, without any actions on our side)
• When using UIP2 components in XB: ValueError: "" is not a valid backing value for enum Drupal\experience_builder\JsonSchemaInterpreter\SdcPropJsonSchemaType in Drupal\experience_builder\JsonSchemaInterpreter\SdcPropJsonSchemaType::from() (line 131 of /src/PropShape/PropShape.php).