Determine if we can remove logger from ImageEffectBase

Created on 22 August 2024, 6 months ago

Problem/Motivation

Follow up from πŸ“Œ Create a trait and base class to implement \Drupal\Component\Plugin\ConfigurableInterface Needs review . from @benjifisher around core/modules/image/src/ImageEffectBase.php

eliminate the constructor and set the $logger property in the create() method?

One comment following was @megachriz

I guess we can, but why would this be needed? And wouldn't that cause issues for classes that extend ImageEffectBase and override the constructor now? In other words: I think removing the $logger property would be a BC break.

Steps to reproduce

N/A

Proposed resolution

Determine if anything can be done

Remaining tasks

Research
If can be removed do it
Else close this out

User interface changes

N/A

Introduced terminology

N/A

API changes

TBD

Data model changes

N/A

Release notes snippet

N/A

πŸ“Œ Task
Status

Active

Version

11.0 πŸ”₯

Component
Image systemΒ  β†’

Last updated 1 day ago

Created by

πŸ‡ΊπŸ‡ΈUnited States smustgrave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024