The XB annotations and labels should not change size when zooming

Some background on this:

When zooming happens, we zoom a <div> outputted by the <Canvas> component by adding transform: scale(...) in an inline style attribute. (Note that we also set the same attribute on the same element elsewhere, just search for style.transform in the codebase.)

The same <div> also outputs <Preview> > <Viewport> where we have the iframe and <Outline> laid out as adjacent elements. <Outline> is where all the annotations and labels live. They all get zoomed, because we scale the <div> which is their ancestor.

I had a chance to discuss this with @jessebaker, and his idea is the following:

1. Move the <style> attribute with the transform: scale(...) further down the component tree to only zoom the contents of the iframe;
2. Move <Outline> out of the <Viewport> component and lay it on top of the iframe with absolute positioning — this will require calculating its position.
3. The <Outline> component needs to be aware of the current zoom level and calculate the dimensions and positioning of the borders it draws around components accordingly.

balintbrews → credited jessebaker → .

Unassigned it for now as per the priority of the issue @soaratul you can pick this.

Assigning it to Atul.

So I'll explain the current state of the MR.

1)

Move the attribute with the transform: scale(...) further down the component tree to only zoom the contents of the iframe;

• Use a state variable in the parent state and pass it as a prop to the child which then does all the magic
• I also tried using forwardRef but was not completely able to get that working.

Using forwardRef sounds like a good approach. Here is the example from the React docs on how to expose a DOM node to the parent component: https://react.dev/reference/react/forwardRef#exposing-a-dom-node-to-the-.... Is this how you tried making it work? Perhaps you could give it another try and show your code if it's still not working?

While continuing the work on this issue, let's keep an eye on 🐛 Remove flickering when preview is being updated Fixed , which will soon land with changes that will affect how we need to solve this issue. Until then, I think it's worth doing the exercise of making forwardRef work, so you clear that complexity first.

I'll create a separate MR for using the forwardRef approach.

I'll try to add the code that i tried for forwardRef.Before that the problem that i faced with the implementation of forwardRef was that we only want the irfameRef from the viewPort so that it can be passed to <Outline> component which is moved out from the ViewPort component, do we really need forwardRef for that?
Isn't there a better/Easy way to approach this?

Describing the current state of MR using forwardRef:-

What's working:-
- I am able to get the iframeRef for the outline component.The outline is place at a static positions using the hardcoded CSS values for now(which we might change subsiquently).
- The outline changes when we switch between the elements.
- The button's annotation are not getting Extra large when zooming(even though it's not correctly positioned).

What's not working:-
- The preview works only for one preview size, that is because we are using the same iframeRef for both the sm and lg previews. Since the ref is mutable and can only be attached to one element at a time, the Outline and Viewport components are both trying to access the same iframeRef, which may be causing the problem.
- I am not able to understand how do i handle the zooming part of the issue.

And as with what Balint mentioned in #10 🐛 The XB annotations and labels should not change size when zooming Needs work does it make sense for us to wait for Remove flickering when preview is being updated 🐛 Remove flickering when preview is being updated Fixed to land or is there something more that need to explore or work on?

Since we will make changes in 3469672-adjust-XB-annotaion-zoom-using-forwardRef MR so closing the other 2 MR's to avoid confusion.

utkarsh_33 → closed merge request !316

utkarsh_33 → closed merge request !304

Uploading the video to make it clear how thing are working until this point.

The Zooming work fine for the width and height calculation but it is not working correctly for the left and top.

I’ve been taking a stab at this issue. My brain is melting though, it's late on Friday and I’ve not managed to get it working after putting a few hours into it.

I think the solution is pretty complex but it would go some way towards allowing the refactor I have just proposed in 🌱 [Proposal] A different approach to the iFrame preview interactions Active - at least laying some groundwork for it.

My theoretical solution is roughly as follows:

We need to be able to have the array of

• At the top level we need an array of refs - I’m thinking this should be stored in a React Context provider because I don't know if storing refs in Redux is a good idea?
• For each viewport size we need to add a ref to that array probably in or above Canvas.tsx
• For each iFrame we render we need to set the appropriate ref in the array to point to the “current” iframe in iFrameSwapper

• We can move out of Viewport.tsx and instead render it as a sibling of the .
• Outline can access the correct iFrame ref via the context
• That will ensure that when the canvas is scaled the Outline is not. But the Outline still knows which iFrame it's supposed to be interacting with because it can get the iFrame ref from the context.

This is now the last issue for 🌱 Milestone 0.1.0: Experience Builder Demo Active ! 🥳

Oh wow, yeah portals is a fantastic idea! I blame my Friday evening brain for not thinking of that!

Brilliant ideas! While using portals would be a solid approach, I was thinking we could try the second idea first — scaling the not-to-be-scaled components by the inverse amount —, given that if we can make it work, it's probably easier, and we may do a rewrite anyway if we decide to go with 🌱 [Proposal] A different approach to the iFrame preview interactions Active .

I have a working MR (!325) for scaling the not-to-be-scaled XB annotations by the inverse of current scale. I think this approach will work!

Here is what's left:

1. More manual testing that the solution indeed works.
2. The "Add section" / "Add component" button starts to look broken at large zoom levels for some reason.
3. Adjusting an existing test to assert that the outer <div> outputted in Outline.tsx has the inline style attribute that cancels out the scaling when zoom is used. This can go into the test case named "Can zoom the canvas with the Zoom Controls".
4. Writing test that ensures that the dimensions of the outline (border shown around selected/hovered component in the preview) are adjusted when zoom is used. This can be as simple as looking at what getBoundingClientRect() returns for the outline's DOM element when zoom level is at 100%, and checking how that changes at different zoom levels.

@utkarsh_33, anything you can tackle from the list above as you start your day on Monday would be super helpful. Let's make this happen before DrupalCon! 💪🏻

Hi @balintbrews, the new implementation seems to work fine, except that Add section/component issue described in #27.2.
I was able to write the test coverages according to what's mentioned in #27.3 and 27.4 🐛 The XB annotations and labels should not change size when zooming Needs work .
I will try to get the work done related to "Add section" / "Add component" button's .

Great work on the tests and everything, @utkarsh_33, thank you! I left you some comments on the test code. I also would love us to explore if there's a better way to address the button width issue.

Tested on Tugboat (see Tugboat link at the top of the issue — yay, 📌 Add Tugboat integration RTBC is already helping! :D) — it seems to work great:

I still have concerns about the tests though. See details on MR.

Now that this is fixed, I think 🐛 Need to update the position of edit dropdown menu while zooming out/in in the canvas Active is worth looking at next by the same people 😇

wim leers → closed merge request !318

Automatically closed - issue fixed for 2 weeks with no activity.