- Issue created by @catch
- Merge request !9288Stop using a data provider in UpdateSemverCoreSecurityCoverageTest → (Closed) created by catch
Left some minor comment may be can be addressed, otherwise +1 changes looks good: used protected from public & removed the dataProvider() reference as well, verified test changes on local, its output on the basis of time & memory usage as follow:
Before applied MR changes test takes : Time:
01:40.590,Memory: 6.00 MBAfter applied MR changes test takes: Time:
00:17.520, Memory: 6.00 MBobserved test & its resources usage improved & attached screenshot as well.
- Status changed to Needs work
3 months ago 1:35pm 23 August 2024 - Status changed to Needs review
3 months ago 1:48pm 23 August 2024 Applied minor suggestion apart from nothing seems to left, Please review moving NR.
- Status changed to RTBC
3 months ago 5:41am 24 August 2024 - 🇫🇷France nod_ Lille
Committed and pushed 04fcdb4758 to 11.x and 77ae3bfce1 to 11.0.x and 45e03ba945 to 10.4.x and 986c71cc27 to 10.3.x. Thanks!
- Status changed to Fixed
3 months ago 9:31am 27 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.