- Issue created by @catch
- First commit to issue fork.
- Merge request !9293issue/3469576: speed up RevisionRevertFormTest. → (Closed) created by pooja_sharma
- Status changed to Needs review
about 1 year ago 5:50pm 22 August 2024 I have used protected in place of public & removed the dataProviders as well however there is left testSubmitForm() in which dataProvider providerSubmitForm used if I tried to removed this dataProvider , then code break , if tried to fix it then code needs to alter which seems out of scope, not sure whether need to remove providerSubmitForm() this dataProvider or not?
PLease review, moving NR
verified test changes on local, its output on the basis of time & memory usage as follow:
Before applied MR changes test takes : Time: 01:34.552, Memory: 4.00 MB
After applied MR changes test takes: Time: 00:46.887, Memory: 4.00 MB
observed test & its resources usage improved & attached screenshot as well, moving to RTBC
- Status changed to RTBC
about 1 year ago 5:53am 23 August 2024 - 🇬🇧United Kingdom catch
This looks great thank you!
Drupal\FunctionalTests\Entity\RevisionRevertFormTest 5 passes 52shttps://git.drupalcode.org/issue/drupal-3469576/-/jobs/2524191
- Status changed to Needs work
about 1 year ago 6:08am 23 August 2024 - 🇬🇧United Kingdom catch
Actually this still needs @group #slow due to the remaining @dataProvider - RTBC with that restored though.
- Status changed to Needs review
about 1 year ago 6:46am 23 August 2024 - Status changed to RTBC
about 1 year ago 7:20am 23 August 2024 - Status changed to Fixed
about 1 year ago 8:42am 23 August 2024 - 🇫🇷France nod_ Lille
Committed and pushed 776869929b to 11.x and c3b658d1a2 to 11.0.x and 85fc6be46d to 10.4.x and 4db3a7b48c to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.