- Issue created by @rkoller
- ๐บ๐ธUnited States smustgrave
Do we know if this is fixed in shepherd.js version past 10.0.1?
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
oh the button markup is generated by sheperd? i've assumed that would be on the tour module and or drupal end? will take a look if i am able to figure it out if sheperd 13 which is the current version i suppose is supporting it.
- ๐บ๐ธUnited States smustgrave
The aria-pressed I believe is in tour module but the upstream issue may already be addressed too
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
i've checked alpha13 of shepherd 12.0.0. ( i guess that is the latest). the dialog element/aria-modal issue for upstream is still necessary. shepherd-element.svelte uses a div and doesnt have the aria-modal attribute either ( i am only on the feedback from mike, just asked him as a reality check before i create the issue upstream). and on the button in shepherd-button.svelt i also dont see aria-pressed nor aria-haspopup. so probably it would make sense to open an issue upstream for that as well. guess both should happen in combination.
- Assigned to smustgrave
- Merge request !57Issue #3469328 by rkoller, smustgrave: Update aria attributes on start tour button โ (Merged) created by smustgrave
- Status changed to Needs review
4 months ago 4:28pm 2 September 2024 - Status changed to RTBC
4 months ago 11:56pm 7 September 2024 - ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
with voiceover i've tested with safari (see and listen in the video), firefox and edge on macos and the dialog popup is announced properly across all browsers. looks good!
in regards of the upstream issue. do you mean opening an issue in regards of aria-haspopup there as well or do you refer to the dialog element topic? for the latter i've already opened an issue: https://github.com/shepherd-pro/shepherd/issues/2959. i am just battling with the shepherd environment run within ddev (the problems are also mentioned on the issue). otherwise i would already tried opening a pull request (or at least tried if i am able to change the markup to a dialog element locally in a first step).
- Status changed to Fixed
4 months ago 12:40am 8 September 2024 - ๐บ๐ธUnited States smustgrave
So currently I'm doing some hacky way to make sure the attributes are there since don't have a way to know if or when it would be fixed upstream in shepherd.
-
smustgrave โ
committed ed858f6f on 2.0.x
Issue #3469328 by rkoller, smustgrave: Update aria attributes on start...
-
smustgrave โ
committed ed858f6f on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.